fix: MLS account not being deleted when logging out - WPB-15774

[jullianm]

WPB-15774 [iOS] Logging out consistently doesn't work (Canary)

Issue

Context: When logging out from MLS account (userA) and logging in with other account (userB) and logging out again it will results in weird behavior (crashes, session corrupted popup or login screen showing expired session message..)
-> app behaves inconsistently when logging out from MLS account.

Causes: When logging out from MLS account, we're deleting everything related to the active session except the account itself because some completion block is not called whereas it should be - whether it is a MLS or Proteus account (works fine if we only test with Proteus accounts).

Solution: Ensure the code responsible to delete account data is properly called when logging out from a MLS account by removing usage of dispatch group.

Testing

Log in with MLS account
Log out
Log in with other account (MLS or Proteus)
Log out
..
-> app should behave consistently when logging in / out from MLS or Proteus accounts (no corrupted session pop up, no crash, no expired session message on login screen..)

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

[netbe]

🚢

[github-actions]

Test Results

1 314 tests   1 312 ✅  2m 5s ⏱️
    1 suites      2 💤
    1 files        0 ❌

Results for commit 6483fb3.

[datadog-wireapp]

Datadog Report

Branch report: fix/mls-log-out-error-other-fix
Commit report: 6f74932
Test service: wire-ios-mono

✅ 0 Failed, 1294 Passed, 2 Skipped, 2m 5.83s Total Time