-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable geometry support, plotting, WKB IO #98
Conversation
If you want to see the stuff in action, here:
|
Yes I think it is a good idea :-) ! I haven't looked closely into this massive PR, though. From what I see you use the BTW I plan to submit another Xvec PR in order to make In CF conventions any data variable having (horizontal) spatial dimensions can be linked to a spatial reference (scalar) variable via its |
This PR looks amazing! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
===========================================
- Coverage 98.70% 80.91% -17.80%
===========================================
Files 4 5 +1
Lines 540 791 +251
===========================================
+ Hits 533 640 +107
- Misses 7 151 +144 ☔ View full report in Codecov by Sentry. |
This is a bit of a best but it got too interlinked that breaking it apart would be pain. It has came to live during a week-long workshop with @loreabad6 and I needed to use the time with her to get the functionality in.
So, this PR is a quite a milestone for Xvec as it:
Tests are still mostly missing as is documentation, so WIP.
@benbovy to store the CRS of variable geometry, I opted for
xproj
as it does precisely what I needed. Is it a good idea? I made sure we don't depend on it yet.