clean: reduce implicit int -> (q)sizetype conversion warnings
#2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenlebantongying
force-pushed
the
clean/ssize_t
branch
4 times, most recently
from
264781d to
622ff15
Compare
shenlebantongying
changed the title
int -> qsizetype conversionint -> (q)sizetype conversion warnings
shenlebantongying
force-pushed
the
clean/ssize_t
branch
from
741e989 to
e4192a1
Compare
shenlebantongying
force-pushed
the
clean/ssize_t
branch
from
e4192a1 to
33e6bd0
Compare
|
shenlebantongying
added a commit
to shenlebantongying/goldendict-ng
that referenced
this pull request
Feb 13, 2025
shenlebantongying
added a commit
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be a legacy of Qt4, where size type is
int.https://doc.qt.io/archives/qt-4.8/qvector.html#size
And also pre C++11 size_type was unsigned (?).
Only warnings in function body is changed (use
autoas much as possible) in this PR. There are a few in function return & calling positions.