Skip to content

Fix KV SLO failure propagation and data checks - #921

Open
KirillKurdyukov wants to merge 3 commits into
mainfrom
fix/slo-kv-checks-20261014
Open

KirillKurdyukov wants to merge 3 commits into
mainfrom
fix/slo-kv-checks-20261014

Conversation

@KirillKurdyukov

@KirillKurdyukov KirillKurdyukov commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Propagate unrecovered Table/Query worker errors to the process and SLO gate.
  • Check independently expected control generations and payloads after the
    existing SDK retry completes, including errors while consuming streams.
  • Keep control tables private to each process and clean them in the existing
    native workload.
  • Keep the original direct-exec entrypoint. Do not add a subprocess launcher,
    environment setup or a cleanup orchestrator to the SDK.

The additional entrypoint wrapper was removed in a separate corrective commit.
The native error, retry and control-data checks are unchanged by that removal.

Validation

  • The existing TestSloControlData cases passed: 3 passed.
  • pip check, sh -n tests/slo/docker-entrypoint.sh and git diff --check
    passed. The entrypoint content and executable mode match the original base.
  • Python 3.14 dependency deprecation warnings remain visible.

Hosted SLO/chaos acceptance is not claimed green. The previous head had failing
native jobs and queued async jobs; the corrective head requires its own CI.
Historical local adapter checks are not a substitute for ordinary Action CI.
Transactional concurrent RMW remains a separate change.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.69%. Comparing base (d6391fb) to head (a8e2ae1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.01%     
==========================================
  Files          99       99              
  Lines       12961    12961              
  Branches     1269     1269              
==========================================
+ Hits        10716    10718       +2     
+ Misses       1794     1793       -1     
+ Partials      451      450       -1     
Flag Coverage Δ
integration 80.47% <ø> (+0.02%) ⬆️
unit 49.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the SLO label Oct 14, 2026
@github-actions

Copy link
Copy Markdown

🌋 SLO Test Results

🔴 4 workload(s) tested — 2 workload(s) exceeded failure thresholds

Commit: a3689bb · View run

Workload Thresholds Duration Report
async-topic 🔴 Failure 11m 📄 Report
async-query 🟢 OK 10m 3s 📄 Report
sync-topic 🟢 OK 10m 2s 📄 Report
sync-query 🔴 Failure 4m 53s 📄 Report

Threshold violations:


Generated by ydb-slo-action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant