Repository navigation
Fix KV SLO failure propagation and data checks - #921
Open
KirillKurdyukov wants to merge 3 commits into
Open
KirillKurdyukov wants to merge 3 commits into
KirillKurdyukov wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 99 99
Lines 12961 12961
Branches 1269 1269
==========================================
+ Hits 10716 10718 +2
+ Misses 1794 1793 -1
+ Partials 451 450 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🌋 SLO Test Results🔴 4 workload(s) tested — 2 workload(s) exceeded failure thresholds
Threshold violations: Generated by ydb-slo-action |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
existing SDK retry completes, including errors while consuming streams.
native workload.
environment setup or a cleanup orchestrator to the SDK.
The additional entrypoint wrapper was removed in a separate corrective commit.
The native error, retry and control-data checks are unchanged by that removal.
Validation
TestSloControlDatacases passed: 3 passed.pip check,sh -n tests/slo/docker-entrypoint.shandgit diff --checkpassed. The entrypoint content and executable mode match the original base.
Hosted SLO/chaos acceptance is not claimed green. The previous head had failing
native jobs and queued async jobs; the corrective head requires its own CI.
Historical local adapter checks are not a substitute for ordinary Action CI.
Transactional concurrent RMW remains a separate change.