Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:Implement watcher behaviour #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP:Implement watcher behaviour #45

wants to merge 2 commits into from

Conversation

gilbertwong96
Copy link
Contributor

Give a better abstraction for eetcd watcher.

See more details in #44.

@gilbertwong96 gilbertwong96 force-pushed the feature/watcher-behaviour branch from d5d53c2 to 909cd2b Compare March 22, 2022 03:33
@gilbertwong96 gilbertwong96 changed the title WIP: Implement watcher behaviour Implement watcher behaviour Mar 22, 2022
zhongwencool
zhongwencool requested changes Apr 9, 2022
View reviewed changes
Copy link
Owner

@zhongwencool zhongwencool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the huge PR!
Sorry for this later review.

the eetcd_wather behavior is pretty complex.
nit: I suggest using gen_statem instead.
It's easier to manage the state.

@gilbertwong96 gilbertwong96 force-pushed the feature/watcher-behaviour branch from 909cd2b to c4f8428 Compare April 12, 2022 06:43
@gilbertwong96 gilbertwong96 force-pushed the feature/watcher-behaviour branch from c4f8428 to ce11c4d Compare June 28, 2022 02:36
@gilbertwong96 gilbertwong96 force-pushed the feature/watcher-behaviour branch from ce11c4d to 9850089 Compare June 28, 2022 14:03
@gilbertwong96
Copy link
Contributor Author

Sorry for such a late response. I have fixed it based on your opinion, and please review it again.

@gilbertwong96
Copy link
Contributor Author

Thanks for the huge PR! Sorry for this later review.

the eetcd_wather behavior is pretty complex. nit: I suggest using gen_statem instead. It's easier to manage the state.

I have turned into the gen_statem, but I think gen_statem here is unnecessary. @zhongwencool

@gilbertwong96 gilbertwong96 changed the title Implement watcher behaviour Draft:Implement watcher behaviour Aug 9, 2022
@gilbertwong96 gilbertwong96 changed the title Draft:Implement watcher behaviour WIP:Implement watcher behaviour Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongwencool zhongwencool zhongwencool requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilbertwong96 @zhongwencool