Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated net spent #1178

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

zancas
Copy link
Member

@zancas zancas commented Jun 1, 2024

Builds directly on dev to separate concerns.

@zancas zancas added the lower priority this PR is not the highest priority for the author label Jun 2, 2024
Oscar-Pepper
Oscar-Pepper previously approved these changes Jun 3, 2024
@zancas zancas dismissed Oscar-Pepper’s stale review June 3, 2024 15:20

The merge-base changed after approval.

@Oscar-Pepper Oscar-Pepper self-requested a review June 3, 2024 15:21
Oscar-Pepper
Oscar-Pepper previously approved these changes Jun 3, 2024
@zancas zancas dismissed Oscar-Pepper’s stale review June 3, 2024 15:29

The merge-base changed after approval.

idky137
idky137 previously approved these changes Jun 3, 2024
@zancas zancas dismissed idky137’s stale review June 3, 2024 15:51

The merge-base changed after approval.

@zancas zancas removed the lower priority this PR is not the highest priority for the author label Jun 3, 2024
@zancas zancas requested review from Oscar-Pepper and idky137 June 3, 2024 18:37
@zancas
Copy link
Member Author

zancas commented Jun 3, 2024

I updated against dev, which obsoleted reviews.

@zancas zancas force-pushed the remove_deprecated_net_spent branch from 5848f12 to 4179677 Compare June 3, 2024 19:30
@zancas zancas added the TOP PRIORITY This is the author's TOP priority, please consider first. label Jun 3, 2024
@zancas
Copy link
Member Author

zancas commented Jun 3, 2024

Based on local test passage, and previous reviews I am merging.

@zancas zancas merged commit 8ec9148 into zingolabs:dev Jun 3, 2024
9 checks passed
@zancas zancas deleted the remove_deprecated_net_spent branch November 30, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOP PRIORITY This is the author's TOP priority, please consider first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants