i18n: Add and update TODO markers after a sweep #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toward zulip#277. These may be tricky to actually handle translating, particularly given the logic in _ensureInitNotificationSounds that looks at the filenames of existing files. They're also in a pretty obscure corner where I expect very few users see them, so not a priority. But they (a) are user-facing and (b) use English words ("chime", "low", "high") to communicate, so are squarely in the category of strings that should in principle get translated. Mark them as such.
We have a number of comments saying `TODO(i18n)`, and just this one saying `TODO(intl)`. The variation makes it less effective at its purpose of being findable with grep.
|
LGTM, thanks! As noted in #277, there's more work before we can declare that issue complete: #277 (comment) |
|
Thanks for catching these! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #277.
Background: #277 (comment)