Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add and update TODO markers after a sweep #1332

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented Feb 5, 2025

Toward #277.

Background: #277 (comment)

Toward zulip#277.

These may be tricky to actually handle translating, particularly
given the logic in _ensureInitNotificationSounds that looks at the
filenames of existing files.  They're also in a pretty obscure
corner where I expect very few users see them, so not a priority.

But they (a) are user-facing and (b) use English words ("chime",
"low", "high") to communicate, so are squarely in the category of
strings that should in principle get translated.  Mark them as such.
We have a number of comments saying `TODO(i18n)`, and just this one
saying `TODO(intl)`.  The variation makes it less effective at its
purpose of being findable with grep.
@gnprice gnprice added the maintainer review PR ready for review by Zulip maintainers label Feb 5, 2025
@chrisbobbe
Copy link
Collaborator

LGTM, thanks! Merging I'll let Zixuan review as I see he's assigned (guess I skipped looking at that 🙂 field before reviewing)

As noted in #277, there's more work before we can declare that issue complete: #277 (comment)

@PIG208
Copy link
Member

PIG208 commented Feb 6, 2025

Thanks for catching these! Merging.

@PIG208 PIG208 merged commit d22a97e into zulip:main Feb 6, 2025
1 check passed
@gnprice gnprice deleted the pr-i18n-todos branch February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants