Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add and update TODO markers after a sweep #1332

Merged
merged 4 commits into from
Feb 6, 2025
Merged

i18n: Add and update TODO markers after a sweep #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
294cce6
notif [nfc]: Note a todo-i18n for display names of notif sound files
gnprice Feb 5, 2025
e0019ee
lightbox [nfc]: Note todo-i18n on video durations
gnprice Feb 5, 2025
64a822e
i18n [nfc]: Standardize a todo-i18n comment, from "intl"
gnprice Feb 5, 2025
d22a97e
i18n [nfc]: Standardize more todo-i18n comments, from free-form
gnprice Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/notifications/display.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ import '../widgets/theme.dart';
AndroidNotificationHostApi get _androidHost => ZulipBinding.instance.androidNotificationHost;

enum NotificationSound {
// Any new entry here must appear in `keep.xml` too, see #528.
// TODO(i18n): translate these file display names
chime2(resourceName: 'chime2', fileDisplayName: 'Zulip - Low Chime.m4a'),
chime3(resourceName: 'chime3', fileDisplayName: 'Zulip - Chime.m4a'),
chime4(resourceName: 'chime4', fileDisplayName: 'Zulip - High Chime.m4a');
// Any new entry here must appear in `keep.xml` too, see #528.

const NotificationSound({
required this.resourceName,
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/content.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,7 @@ class GlobalTime extends StatelessWidget {
final GlobalTimeNode node;
final TextStyle ambientTextStyle;

static final _dateFormat = DateFormat('EEE, MMM d, y, h:mm a'); // TODO(intl): localize date
static final _dateFormat = DateFormat('EEE, MMM d, y, h:mm a'); // TODO(i18n): localize date

@override
Widget build(BuildContext context) {
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/lightbox.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ class VideoDurationLabel extends StatelessWidget {
final hours = value.inHours.toString().padLeft(2, '0');
final minutes = value.inMinutes.remainder(60).toString().padLeft(2, '0');
final seconds = value.inSeconds.remainder(60).toString().padLeft(2, '0');
return '${hours == '00' ? '' : '$hours:'}$minutes:$seconds';
return '${hours == '00' ? '' : '$hours:'}$minutes:$seconds'; // TODO(i18n)
}

@override
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/message_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,5 +1410,5 @@ class MessageWithPossibleSender extends StatelessWidget {
}
}

// TODO web seems to ignore locale in formatting time, but we could do better
// TODO(i18n): web seems to ignore locale in formatting time, but we could do better
final _kMessageTimestampFormat = DateFormat('h:mm aa', 'en_US');
2 changes: 1 addition & 1 deletion lib/widgets/profile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ class _ProfileDataTable extends StatelessWidget {
// TODO(server): The value's format is undocumented, but empirically
// it's a date in ISO format, like 2000-01-01.
// That's readable as is, but:
// TODO format this date using user's locale.
// TODO(i18n) format this date using user's locale.
return _TextWidget(text: value);

case CustomProfileFieldType.shortText:
Expand Down