fix: escape single quotes in narrow links #2115
Conversation
|
This PR needs tests before it can be reviewed. Also please edit the commit message to follow the project guidelines. |
moksha-hub
force-pushed
the
fix/2105-escape-single-quotes-in-narrow-links
branch
from
68c5b99 to
7ce5991
Compare
|
Marking this as draft for now to get it out of our queue. @moksha-hub please go ahead and unmark this PR as draft when it's ready for review. |
Add single quote (') to the list of characters that are dot-encoded in narrow link URLs. Some software with URL detection heuristics may interpret a single quote as the end of a URL, causing links to break.
This aligns with the behavior needed for consistent URL detection across different platforms and messaging clients.
Fixes zulip#2105
moksha-hub
force-pushed
the
fix/2105-escape-single-quotes-in-narrow-links
branch
from
7ce5991 to
85cbeb0
Compare
|
I've added the requested tests for single quote escaping and updated the commit message. Regarding the CI failure: The build failed with a Java compilation error in the @gnprice @chrisbobbe Please let me know The failure wasn't related to my side of issue I guess.. |
3 participants
Add single quote (') to the list of characters that are dot-encoded in narrow link URLs. Some software with URL detection heuristics may interpret a single quote as the end of a URL, causing links to break.
This aligns with the behavior needed for consistent URL detection across different platforms and messaging clients.
Fixes #2105