Migrate procfs memory module under procfs/ #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
Merged
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
2d8f756 to
77b5305
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
edc6daf to
b94deb7
Compare
This was referenced Dec 4, 2024
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
77b5305 to
8ca762a
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
b94deb7 to
544087e
Compare
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
8ca762a to
b1048f9
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
544087e to
ae3eb50
Compare
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
from
b1048f9 to
2376bfa
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
ae3eb50 to
4cbdb7e
Compare
This was referenced Dec 5, 2024
GeorgeHahn
approved these changes
Dec 5, 2024
blt
force-pushed
the
blt/read_all_cgroup_v2_metrics_that_can_be_read
branch
2 times, most recently
from
8e49816 to
2f79087
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
2 times, most recently
from
507dba5 to
32ffba5
Compare
This was referenced Dec 6, 2024
Merged
blt
changed the base branch from
blt/read_all_cgroup_v2_metrics_that_can_be_read
to
graphite-base/1124
blt
force-pushed
the
graphite-base/1124
branch
from
67078d8 to
d2a93c4
Compare
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
32ffba5 to
35e30a7
Compare
In practice the `memory.rs` is only used by the procfs sampler. This commit migrates the code to match its use. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/migrate_procfs_memory_module_under_procfs_
branch
from
35e30a7 to
6bd55f6
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In practice the
memory.rsis only used by the procfs sampler. Thiscommit migrates the code to match its use.