Rely on metrics registry to expire metrics #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
This was referenced Dec 5, 2024
GeorgeHahn
approved these changes
Dec 5, 2024
blt
force-pushed
the
blt/remove_target_rss_byte_tracking
branch
from
21d94ca to
729e6b0
Compare
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
30eaa78 to
aee2f25
Compare
blt
force-pushed
the
blt/remove_target_rss_byte_tracking
branch
from
729e6b0 to
77022ae
Compare
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
aee2f25 to
505495c
Compare
This was referenced Dec 6, 2024
Merged
blt
force-pushed
the
blt/remove_target_rss_byte_tracking
branch
from
77022ae to
36bb8a4
Compare
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
505495c to
b5da7f7
Compare
blt
force-pushed
the
blt/remove_target_rss_byte_tracking
branch
2 times, most recently
from
8d9e720 to
21e0c34
Compare
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
b5da7f7 to
41b64d0
Compare
blt
changed the base branch from
blt/remove_target_rss_byte_tracking
to
graphite-base/1128
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
41b64d0 to
9d976fa
Compare
blt
force-pushed
the
graphite-base/1128
branch
from
21e0c34 to
887a8b2
Compare
This commit removes the Gauge zero-set in the procfs sampler, relying now on the work done in #1125 to expire metrics that are no longer written to. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/rely_on_metrics_registry_to_expire_metrics
branch
from
9d976fa to
11b96bd
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes the Gauge zero-set in the procfs sampler, relying now
on the work done in #1125 to expire metrics that are no longer written
to.