Slim out joinset #1133
Merged
Slim out joinset #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2024
blt
force-pushed
the
blt/slim_out_joinset
branch
3 times, most recently
from
38e96c1 to
6055d12
Compare
GeorgeHahn
approved these changes
Dec 6, 2024
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
from
b3f9606 to
e8d0095
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
from
6055d12 to
c5ff9b3
Compare
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
from
e8d0095 to
237e686
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
from
c5ff9b3 to
b91521a
Compare
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
from
237e686 to
2a09dca
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
from
b91521a to
d304542
Compare
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
from
2a09dca to
e4a843b
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
from
d304542 to
9f7428e
Compare
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
from
e4a843b to
2cbeb08
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
4 times, most recently
from
06d7bab to
42af96f
Compare
blt
force-pushed
the
blt/expand_smaps___smaps_rollup_parsing
branch
2 times, most recently
from
7877403 to
89c9fb1
Compare
blt
force-pushed
the
blt/slim_out_joinset
branch
from
42af96f to
e7ffc27
Compare
blt
changed the base branch from
blt/expand_smaps___smaps_rollup_parsing
to
graphite-base/1133
scottopell
approved these changes
Dec 6, 2024
blt
force-pushed
the
blt/slim_out_joinset
branch
from
e7ffc27 to
e26e932
Compare
blt
force-pushed
the
graphite-base/1133
branch
from
89c9fb1 to
d767aa4
Compare
This commit removes a joinset in the inner polling loop of the procfs sampler. The existence of the joinset makes calculation of total_pss, total_rss more difficult and its unclear that there is a performance boost by its existence. Signed-off-by: Brian L. Troutwine <[email protected]>
blt
force-pushed
the
blt/slim_out_joinset
branch
from
e26e932 to
88a426e
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes a joinset in the inner polling loop of the procfs
sampler. The existence of the joinset makes calculation of total_pss,
total_rss more difficult and its unclear that there is a performance
boost by its existence.