Skip to content

Commit

Permalink
fix UCAL host assistance mode for d430 mipi skus
Browse files Browse the repository at this point in the history
  • Loading branch information
gwen2018 committed Jan 31, 2025
1 parent 91f4472 commit a53e1e4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
7 changes: 5 additions & 2 deletions common/on-chip-calib.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ namespace rs2
device_name_string = _dev.get_info( RS2_CAMERA_INFO_NAME );
if( val_in_range( device_name_string, { std::string( "Intel RealSense D415" ) } ) )
speed = 4;

if ( strcmp(_dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID), "ABCD") || strcmp(_dev.get_info(RS2_CAMERA_INFO_PRODUCT_ID), "ABCE"))
is_mipi_sku = true;
}
if (dev.supports(RS2_CAMERA_INFO_FIRMWARE_VERSION))
{
Expand Down Expand Up @@ -2088,7 +2091,7 @@ namespace rs2
ImGui::SetTooltip("%s", "Calculate ground truth for the specific target");

ImGui::SetCursorScreenPos({ float(x + 9), float(y + height - ImGui::GetTextLineHeightWithSpacing() - 30) });
get_manager().host_assistance = (get_manager().device_name_string == std::string("Intel RealSense D457") ); // To be used for MIPI SKU only
get_manager().host_assistance = get_manager().is_mipi_sku; // To be used for MIPI SKU only
bool assistance = (get_manager().host_assistance != 0);
if (ImGui::Checkbox("Host Assistance", &assistance))
get_manager().host_assistance = (assistance ? 1 : 0);
Expand Down Expand Up @@ -2184,7 +2187,7 @@ namespace rs2
// ImGui::SetTooltip("%s", "On-Chip Calibration Extended");

ImGui::SetCursorScreenPos({ float(x + 9), float(y + height - ImGui::GetTextLineHeightWithSpacing() - 31) });
get_manager().host_assistance = (get_manager().device_name_string == std::string("Intel RealSense D457") ); // To be used for MIPI SKU only
get_manager().host_assistance = get_manager().is_mipi_sku; // To be used for MIPI SKU only
bool assistance = (get_manager().host_assistance != 0);
ImGui::Checkbox("Host Assistance", &assistance);
if (ImGui::IsItemHovered())
Expand Down
1 change: 1 addition & 0 deletions common/on-chip-calib.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ namespace rs2
const std::string Z16_FORMAT = "Z16";
const std::string RGB8_FORMAT = "RGB8";
std::string device_name_string;
bool is_mipi_sku = false;

void calibrate();
void calibrate_fl();
Expand Down
2 changes: 1 addition & 1 deletion include/librealsense2/rs.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ extern "C" {

#define RS2_API_MAJOR_VERSION 2
#define RS2_API_MINOR_VERSION 57
#define RS2_API_PATCH_VERSION 52
#define RS2_API_PATCH_VERSION 53
#define RS2_API_BUILD_VERSION 0

#ifndef STRINGIFY
Expand Down

0 comments on commit a53e1e4

Please sign in to comment.