-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to add pixi.toml and to reflect move away from robostack-staging channel #73
Conversation
Changed installation > installing for clarity
Draft pixi.toml for comment. #create the pixi project folder and pixi.toml file
pixi init robostack
#move to the pixi project folder
cd robostack Open the created pixi.toml in any text editor and paste the below into the file (remove the configuration created by
Save and Exit
ROS humble
ROS jazzy
|
Thanks! Regarding the section:
As of the latest version of February 2025, the |
Thanks for the heads up. Will have a look at that when I get a chance. |
Have set this up using tabs rather than sub-pages under gettingstarted. Tabs separate the page into mamba/pixi. At the moment the intention is for users to copy the pixi.toml config from the getting started guide and paste it into their own local copy created by pixi init __. But I'm not sure if I'm 100% happy with that solution. Any thoughts/comments/concerns? It also looks like we're still blocked by #74, so not quite ready to merge yet. |
Having some issues with the environments and need to figure out if it's because of Windows or my pixi.toml.. |
Thanks for this! I think this is great.
I think this is probably a good idea. Once pixi will have more advanced templating capability we can use it (see prefix-dev/pixi#2837), but for now a good&old documentation to copy paste is already a great improvement on the current status quo. |
I opened RoboStack/ros-noetic#506 to unblock the situation on the noetic side. |
Humble and Jazzy environments tested and working. |
I am happy to report that all environments are now installing and activating correctly from the prefix.dev channels. This updated documentation should be good to go. |
Thanks a lot for all the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some minor comments inline, but as this is already a huge improvements over the status quo, for me the PR could also be merged as it is and do the improvements in follow up PRs.
Removed explicit setting of python version. Co-authored-by: Silvio Traversaro <[email protected]>
Co-authored-by: Silvio Traversaro <[email protected]>
Co-authored-by: Silvio Traversaro <[email protected]>
batch commit with suggestions implemented Co-authored-by: Silvio Traversaro <[email protected]>
Suggestions committed, thanks @traversaro! |
Thanks a lot @TedVanderfeen - this is great! And thanks for the review @traversaro. |
|
||
!!! warning "PowerShell is not supported" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Powershell works for us? It can currupt the environment when using poxi shell, but that is the same for cmd. I thought the no PS support was a mamba issue?
mamba activate ros_env | ||
rviz | ||
Open the newly created pixi.toml in your favourite text editor and paste the below configuration into the file (overwriting the configuration created by `pixi init`): | ||
``` bash title="pixi.toml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add the automatic sourcing of the ros workspace environment on activation, and a default build task/command that includes cmake flags pointing python to the virtual installs
|
||
!!! note | ||
Remember that Pixi environments can only be activated from within your project directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not technically true, they initialise by default from the project directory
roscore | ||
``` | ||
|
||
```bash title="Second terminal" | ||
micromamba activate ros_env | ||
cd robostack | ||
pixi shell -e noetic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or just pixi run rviz
Initial change so that I can open the PR:
Changed installation > installing for clarity
Addresses #67 and better reflects #68