Node 10 support on linux

[hannseman]

I understand that the main purpose of this package is to bring support for macOS Mojave but I would like to ask you if you could consider depending on https://github.com/abandonware/noble which fixes Node 10 support for linux. This is the root issue noble/node-bluetooth-hci-socket#84.

This would enable people who have to support both macOS Mojave and Node >=10 on Linux to use this library.

[geovie]

Hi, for now I won't change from noble/noble to abandonware/noble as it is already possible to use a custom noble (abandonware/noble or any other) by using noble-mac as binding only (take a look at index.js).
However, I'd like to integrate noble-mac directly in to noble, so if abandonware/noble is actively maintained and they're interested in Mojave support, I'm happy to create a PR.

[hannseman]

@geovie looks like abandonware/noble is interested in integrating. Please see abandonware/noble#4.

That fork is pretty popular with 1600 weekly downloads.
https://www.npmjs.com/package/@abandonware/noble

Compare that to the original package with has 1800 weekly downloads.
https://www.npmjs.com/package/noble

[rzr]

Are there any patches from this fork that are pending upstream ?

If yes they could be merged into @abandonware/noble

Again efforts to track changes are appreciated:
abandonware/noble#2

[geovie]

@rzr No @abandonware/noble already contains the latest changes abandonware/noble#8

[rzr]

Feel free to rebase on @abandonware/noble if you want, I plan to keep it based on upstream too