Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS Mojave support #4

Closed
hannseman opened this issue Dec 27, 2018 · 5 comments · Fixed by #8
Closed

MacOS Mojave support #4

hannseman opened this issue Dec 27, 2018 · 5 comments · Fixed by #8

Comments

@hannseman
Copy link

hannseman commented Dec 27, 2018 •
edited
Loading

Hi!

Thank you very much for taking the initiative to create a maintainable fork. I understand that this fork mainly was created for getting support for Node >=10 but another big issue that noble has is missing support for MacOS Mojave. This PR noble#840 fixes this and because of noble being unmaintained the PR author created a new package noble-mac - https://github.com/Timeular/noble-mac.

It would be preferable to only have one fork. Maybe noble#840 could be merged into this repository and start a discussion with the noble-mac author about making contributions to this repository instead?
This was referenced Jan 21, 2019
Merged
Closed
@hannseman
Copy link
Author

Please see Timeular/noble-mac#23 (comment)

@rzr
Copy link

rzr commented Feb 7, 2019

Hi @hannseman

Best option would be that upstream is rebasing on abandonware fork. I have not osx device I could use, eventually one could setup a build bot to check any PR on this repo ?

@hannseman hannseman mentioned this issue Feb 7, 2019
Closed
@hannseman
Copy link
Author

You already have Travis CI configured to run the test suite on OSX.

@rzr
Copy link

rzr commented Feb 8, 2019

Oh yes osx is listed in:
https://github.com/abandonware/noble/blob/master/.travis.yml#L3

Please confirm, that what we have is working fine,
maybe we could do continuous delivery too,
I am used to jfrog's bintray , maybe other could be suggested ?

BTW the link in readme is wrong it should be:
https://travis-ci.org/abandonware/noble/jobs/
feel free to patch this
@hannseman

May I suggest @Timeular to rebase your branch on @abandonware noble's master ?

@geovie geovie mentioned this issue Feb 21, 2019
Merged
@geovie
Copy link

geovie commented Feb 21, 2019

@rzr I've made a PR with the latest noble-mac changes to this repo

@rzr rzr closed this as completed in #8 Apr 15, 2019
@manuelnaturalcycles manuelnaturalcycles mentioned this issue Aug 6, 2019
Open
pfafman pushed a commit to pfafman/noble that referenced this issue Dec 30, 2024
@stoprocent
fix(hci): update to the hci layer to address the issues on ubuntu 24 (a…
c2feb69 
…bandonware#5)

* fix(hci): updating hci dependency to address ubuntu issue abandonware#4

* chore(lock): updating package

* fix(prebuildify-cross): patching packages to fix prebuilding

* chore(package): cleanup of dependencies

* chore(lint): minor updates to eslint

* chore(lint): enable ES6 syntax

* chore(actions): update codecov to v4

---------

Co-authored-by: Marek Serafin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Native mac bindings Timeular/noble
3 participants
@rzr @hannseman @geovie