Skip to content

Use http-cache for web assets #20791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mrchantey wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Use http-cache for web assets #20791

mrchantey wants to merge 10 commits into from
+102 −108

Conversation

@mrchantey
Copy link
Contributor

@mrchantey mrchantey commented Aug 30, 2025 •
edited
Loading

Objective

The current web assets impl has a placeholder cache that never invalidates, the http-cache-ureq crate provides proper http caching mechanism, which is non-trivial to implement ourselves.

Solution

  • Replace placeholder cache with http-cache-ureq

Testing

Verify with cargo run --example web_asset --features=https,web_asset_cache

Updates

@mrchantey mrchantey mentioned this pull request Aug 30, 2025
Open
@mrchantey mrchantey added A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on S-Blocked This cannot move forward until something else changes labels Aug 30, 2025
@mrchantey
Merge origin/main into web-asset-http-cache
2b987fc
@mrchantey
Fix http-cache integration: remove double await and unblock wrapper
ce84923 
- call() is already async in http-cache-ureq v1.0.0-alpha.2
- The library handles async execution internally with smol::unblock
- Removed unnecessary unblock wrapper from cached path
- Keep unblock for non-cached path since plain ureq is synchronous
@mrchantey mrchantey changed the title Draft: use http-cache for web assets Use http-cache for web assets Jan 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

You added a new example but didn't add metadata for it. Please update the root Cargo.toml file.

@mrchantey mrchantey added C-Feature A new feature, making something new possible and removed S-Blocked This cannot move forward until something else changes labels Jan 21, 2026
@mrchantey
Copy link
Contributor Author

mrchantey commented Jan 21, 2026 •
edited
Loading

Currently failing due to prelease git dep http-cache-ureq, the author has been helping us with our deps and licence requirements which we've recently resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Dependencies A change to the crates that Bevy depends on C-Feature A new feature, making something new possible

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mrchantey