Skip to content

Conversation

TeamDman
Copy link
Contributor

Objective

Fixes #21528 causing the main branch to not build when not using default features

Solution

Added explicit dependencies on morph feature for bevy_mesh and bevy_render for bevy_pbr

Testing

Now builds successfully on my machine using

cargo build --no-default-features --features std,x11,bevy_winit,bevy_state,bevy_window,bevy_pbr,bevy_sprite,bevy_text,bevy_core_pipeline,bevy_picking,bevy_animation,png,zstd_rust,tonemapping_luts,ktx2

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 17:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds explicit dependencies on the "morph" feature for bevy_mesh and bevy_render in bevy_pbr to fix a build issue when not using default features.

  • Adds "morph" and "bevy_mikktspace" features to bevy_mesh dependency
  • Adds "morph" feature to bevy_render dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alice-i-cecile alice-i-cecile requested a review from atlv24 October 13, 2025 17:26
@alice-i-cecile alice-i-cecile added this to the 0.17.3 milestone Oct 13, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Oct 13, 2025
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 13, 2025
@alice-i-cecile
Copy link
Member

CI is complaining about formatting, but the core idea is good so I've approved. You'll need to fix that before we can merge.

@atlv24 atlv24 removed this from the 0.17.3 milestone Oct 14, 2025
Copy link
Contributor

@atlv24 atlv24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, note that this is not a problem present on 0.17 as my morph pr landed in 0.18

@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Oct 14, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 14, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 14, 2025
Merged via the queue into bevyengine:main with commit fcd5c26 Oct 14, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Fails to build on main without bevy_mesh/morph feature

3 participants