Skip to content

Avoid creating a pass for main_transparent_pass_2d when unecessary #24850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PJB3005 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

Avoid creating a pass for main_transparent_pass_2d when unecessary #24850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/bevy_core_pipeline/src/core_2d/main_transparent_pass_2d_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ pub fn main_transparent_pass_2d(
return;
};

if transparent_phase.items.is_empty() {
return;
}

#[cfg(feature = "trace")]
let _span = info_span!("main_transparent_pass_2d").entered();

Expand Down Expand Up @@ -61,12 +65,10 @@ pub fn main_transparent_pass_2d(
render_pass.set_camera_viewport(viewport);
}

if !transparent_phase.items.is_empty() {
#[cfg(feature = "trace")]
let _transparent_span = info_span!("transparent_main_pass_2d").entered();
if let Err(err) = transparent_phase.render(&mut render_pass, world, view_entity) {
error!("Error encountered while rendering the transparent 2D phase {err:?}");
}
#[cfg(feature = "trace")]
let _transparent_span = info_span!("transparent_main_pass_2d").entered();
if let Err(err) = transparent_phase.render(&mut render_pass, world, view_entity) {
error!("Error encountered while rendering the transparent 2D phase {err:?}");
}

pass_span.end(&mut render_pass);
Expand Down
Loading