make window lifecycle/meta events observable - #25702
Open
laundmo wants to merge 1 commit into
Open
Conversation
laundmo
added
A-Windowing
This was referenced Sep 6, 2026
laundmo
added
the
S-Adopt-Me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Make some window "events" actual events, in addition to messages.
Alternative to
Solution
In #25567 the issue of performance of things like pointer move events was raised. These could theoretically happen thousands of times per frame, making them a potentially bad fit for observers.
This PR is a stripped-back version of #25567 which only keeps the Event implementations for "window lifecycle"/meta events, those which happen rarely, such as windows being created, resized, destroyed, the scale factor changing, a file being dropped on the window, etc.
Testing
cargo checkTODO if we go forward with this