Skip to content

Solari: Scene bindings for environment map light - #25703

Open
JMS55 wants to merge 2 commits into
bevyengine:mainfrom
JMS55:solari8-envmap
Open

Solari: Scene bindings for environment map light#25703
JMS55 wants to merge 2 commits into
bevyengine:mainfrom
JMS55:solari8-envmap

Conversation

@JMS55

@JMS55 JMS55 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Objective

  • Setup scene bindings for atmosphere/envmaplight/skybox/etc for solari.
  • Using the envmap for lighting will be a future PR.

Solution

AI generated and cleaned up by me.

  • Skybox does not need any handling in Solari - opaque main pass will write it after pathtracing. The only exception is that the reference pathtracer will not show the skybox. Imo this is fine, we could always update the pathtracer to show it later if needed.
  • Atmosphere uses GeneratedEnvironmentMapLight, and Skybox with lighting uses EnvironmentMapLight. So find one or the other, and extract it to ExtractedEnvironmentMapLight. Then use the underlying cubemap for lighting.
  • If more than one camera has different envmaps, use the first one, and warn the user. Per-camera envmap is not currently supported.
  • Always sample mip 0 (unfiltered radiance). In the future, we could track path spread and use that to sample other MIPs.
  • No infrastructure setup to use an env map as a light source for NEE atm. That can be a followup as well.

Testing

Tested in solari.rs in a future PR that also changes lighting

@JMS55 JMS55 added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 6, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Sep 6, 2026
@JMS55
JMS55 requested a review from IceSentry September 6, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

1 participant