-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Port from CDP to BiDi browser automation #20832
Merged
allisonkarlitskaya
merged 7 commits into
cockpit-project:main
from
martinpitt:bidi-browser
Aug 13, 2024
Merged
test: Port from CDP to BiDi browser automation #20832
allisonkarlitskaya
merged 7 commits into
cockpit-project:main
from
martinpitt:bidi-browser
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31b4789
to
fa5e773
Compare
This was referenced Aug 2, 2024
3388811
to
5fc99c8
Compare
6 tasks
5fc99c8
to
d32f536
Compare
68c1813
to
00738d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
00738d8
to
edcec61
Compare
This comment was marked as resolved.
This comment was marked as resolved.
martinpitt
added a commit
to martinpitt/cockpit-ostree
that referenced
this pull request
Aug 13, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
1 task
martinpitt
added a commit
to cockpit-project/cockpit-podman
that referenced
this pull request
Aug 13, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Also sort package.json properly (done by `npm install --save-dev`).
martinpitt
added a commit
to martinpitt/cockpit-machines
that referenced
this pull request
Aug 13, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. This causes some minor pixel test noise, adjust the references.
allisonkarlitskaya
pushed a commit
to cockpit-project/starter-kit
that referenced
this pull request
Aug 13, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpit-files
that referenced
this pull request
Aug 13, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Adjust `waitDownloadFile()` to the new download directory attribute. This is a `Path` object now, which is more convenient.
martinpitt
added a commit
to martinpitt/cockpit-ostree
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
martinpitt
added a commit
to martinpitt/cockpit-machines
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. This causes some minor pixel test noise, adjust the references.
martinpitt
added a commit
to martinpitt/cockpit-machines
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. This causes some minor pixel test noise, adjust the references.
KKoukiou
added a commit
to KKoukiou/anaconda-webui
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
martinpitt
added a commit
to cockpit-project/cockpit-ostree
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
martinpitt
added a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. This causes some minor pixel test noise, adjust the references.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 14, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
KKoukiou
added a commit
to KKoukiou/anaconda-webui
that referenced
this pull request
Aug 15, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Adjust the exception handling tests to not wait for RuntimeError, this is no longer raised.
KKoukiou
added a commit
to KKoukiou/anaconda-webui
that referenced
this pull request
Aug 15, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Adjust the exception handling tests to not wait for RuntimeError, this is no longer raised.
KKoukiou
added a commit
to KKoukiou/anaconda-webui
that referenced
this pull request
Aug 15, 2024
See cockpit-project/cockpit#20832 Drop chrome-remote-interface NPM dependency. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Adjust the exception handling tests to not wait for RuntimeError, this is no longer raised. Also switch_to_top frame when waiting for the error dialog (no idea how it worked before). Lastly make the CockpitJSErrorHandling test nondestructive.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 20, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 20, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 20, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 20, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to croissanne/cockpit-composer
that referenced
this pull request
Aug 20, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
croissanne
added a commit
to osbuild/cockpit-composer
that referenced
this pull request
Aug 21, 2024
See cockpit-project/cockpit#20832. Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a. It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookie["sameSite"]
check "strict" again (see Various test fixes #20868 (comment))Remove the "pixel-test" CSS hack to hide global scrollbars(still needed)Follow-ups: