fix: show clear frontend error when file size exceeds limit #2929 #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @RitvikSardana, I'm following up on this PR which addresses the silent file upload failures in issue #2929. I have refactored the uploadFunction in utils.ts to be asynchronous and implemented a specific error handling block that detects 413 and 417 status codes. This ensures users receive a clear 'File too large' toast notification instead of no feedback. The automated checks have passed successfully. Could you please take a look when you have a moment? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a silent failure when file uploads exceed server capacity.
Changes:
Modified uploadFunction in utils.ts to be async.
Added a robust try...catch block that inspects error.status (413/417) and message strings.
Users now receive a specific "File too large" toast instead of a generic failure.
Closes #2929