Skip to content

fix: show clear frontend error when file size exceeds limit #2929 #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Valley-15 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: show clear frontend error when file size exceeds limit #2929 #2946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions desk/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,17 +302,34 @@ export function getGridTemplateColumnsForTable(columns) {
return columnsWidth + " 22px";
}

export function uploadFunction(
export async function uploadFunction(
file: File,
doctype: string = null,
docname: string = null
) {
let fileUpload = useFileUpload();
return fileUpload.upload(file, {
private: true,
doctype: doctype,
docname: docname,
});
try {
return await fileUpload.upload(file, {
private: true,
doctype: doctype,
docname: docname,
});
} catch (error: any) {
let message = error.message || "";
const status = error.status || error.xhr?.status || error.response?.status;

// Detection for 413 (Too Large) or 417 (Backend Failure)
if (status === 413 || message.toLowerCase().includes("exceeds") || message.toLowerCase().includes("large")) {
message = "File too large. Please upload a smaller file.";
} else if (status === 417) {
message = "Server rejected the upload. Please check file permissions or try a different format.";
} else {
message = message || "Error uploading file";
}

toast.error(message);
throw error;
}
}

export const convertToConditions = ({
Expand Down