Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Interview Feedback): type cast user input for "rating" field to float #1799

Merged
merged 1 commit into from
May 22, 2024
Merged

fix(Interview Feedback): type cast user input for "rating" field to float #1799

merged 1 commit into from
May 22, 2024

Conversation

vinyselopal
Copy link
Contributor

Before: Data imported using CSV, throws "TypeError: unsupported operand type(s) for +=: 'int' and 'str'
" error when calculating average rating in Interview Feedback, because the rating being str.
After: Type cast rating to avoid incompatible user input

@vinyselopal vinyselopal requested a review from ruchamahabal as a code owner May 22, 2024 06:11
@ruchamahabal ruchamahabal merged commit cb8ac7e into frappe:develop May 22, 2024
8 checks passed
mergify bot pushed a commit that referenced this pull request May 22, 2024
@vinyselopal @mergify
fix(Interview Feedback): type cast user input for "rating" field to f…
914ae04 
…loat (#1799)

(cherry picked from commit cb8ac7e)
@mergify mergify bot mentioned this pull request May 22, 2024
Merged
mergify bot pushed a commit that referenced this pull request May 22, 2024
@vinyselopal @mergify
fix(Interview Feedback): type cast user input for "rating" field to f…
0b9935a 
…loat (#1799)

(cherry picked from commit cb8ac7e)
@mergify mergify bot mentioned this pull request May 22, 2024
Merged
ruchamahabal pushed a commit that referenced this pull request May 22, 2024
@mergify @vinyselopal
fix(Interview Feedback): type cast user input for "rating" field to f…
cef40bd 
…loat (backport #1799) (#1801)

(cherry picked from commit cb8ac7e)

Co-authored-by: Viny Selopal <[email protected]>
ruchamahabal pushed a commit that referenced this pull request May 22, 2024
@mergify @vinyselopal
fix(Interview Feedback): type cast user input for "rating" field to f…
4ed93bd 
…loat (backport #1799) (#1800)

(cherry picked from commit cb8ac7e)

Co-authored-by: Viny Selopal <[email protected]>
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
@frappe-bot
chore(release): Bumped to Version 14.28.1
5a61dcf 
## [14.28.1](v14.28.0...v14.28.1) (2024-05-22)

### Bug Fixes

* added missing args ([9d2611f](9d2611f))
* **Interview Feedback:** type cast user input for "rating" field to float (backport [#1799](#1799)) ([#1800](#1800)) ([4ed93bd](4ed93bd))
frappe-pr-bot pushed a commit that referenced this pull request May 22, 2024
@frappe-bot
chore(release): Bumped to Version 15.21.1
6549e27 
## [15.21.1](v15.21.0...v15.21.1) (2024-05-22)

### Bug Fixes

* added missing args ([05ed004](05ed004))
* **Interview Feedback:** type cast user input for "rating" field to float (backport [#1799](#1799)) ([#1801](#1801)) ([cef40bd](cef40bd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

Assignees
No one assigned
Labels
backport version-14-hotfix backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinyselopal @ruchamahabal