Fix duplicate dropdown dividers #32760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This was referenced Dec 8, 2024
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-dropdown-divider
branch
from
8cd7684 to
2c2d3fb
Compare
github-actions
bot
added
modifies/templates
wxiaoguang
changed the title
Closed
wxiaoguang
force-pushed
the
fix-dropdown-divider
branch
2 times, most recently
from
0526099 to
e9973e7
Compare
wxiaoguang
force-pushed
the
fix-dropdown-divider
branch
from
e9973e7 to
2c71d33
Compare
|
Tested everthing works |
lunny
approved these changes
Dec 9, 2024
GiteaBot
added
lgtm/need 1
kerwin612
approved these changes
Dec 9, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 10, 2024
* giteaofficial/main: Make RepoActionView.vue support `##[group]` (go-gitea#32770) [skip ci] Updated translations via Crowdin Make Monaco theme follow browser, fully type codeeditor.ts (go-gitea#32756) Fix duplicate dropdown dividers (go-gitea#32760) Remove unnecessary border in repo home page sidebar (go-gitea#32767)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27466
The problem is that any item in the menu could be hidden, pure CSS won't work, and dropdown's builtin "hideDividers" doesn't work with our "scope dividers". The newly introduced "archived" label makes the dividers regression more.
Before (duplicate / incorrect dividers):
After:
By the way, the lint rule
unicorn/consistent-function-scopingdoesn't help really our code and might force to do unnecessary code moving during refactoring, so disable it (and then aeslint-disable-linecould be removed)