Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes custom sim params from Isaac-Stack-Cube-Franka-IK-Rel-v0 #1853

Conversation

peterd-NV
Copy link
Contributor

Description

This change removes the custom sim parameters used for the Isaac-Stack-Cube-Franka-IK-Rel-v0 env, setting it to use the same sim parameters as the base environment config class and aligning it with the other Franka stacking environments. This change increases simulation stability and performance.

Type of change

  • Performance enhancement (non-breaking change which improves an existing feature)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have run the pre-commit checks with ./isaaclab.sh --format
  • [] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@kellyguo11 kellyguo11 changed the title Remove custom sim params from Isaac-Stack-Cube-Franka-IK-Rel-v0 Removes custom sim params from Isaac-Stack-Cube-Franka-IK-Rel-v0 Feb 13, 2025
@kellyguo11 kellyguo11 merged commit b9ad448 into isaac-sim:main Feb 13, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants