Adds new Collision Mesh Schema properties #2249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to contributors list Signed-off-by: Harsh Patel <[email protected]>
jsmith-bdai
approved these changes
Apr 8, 2025
| See :meth:`set_mesh_collision_properties` for more information. | ||
|
|
||
| .. note:: | ||
| If the values are None, they are not modified. This is useful when you want to set only a subset of |
There was a problem hiding this comment.
Suggested change
| If the values are None, they are not modified. This is useful when you want to set only a subset of | |
| If the values are MISSING, they are not modified. This is useful when you want to set only a subset of |
| @@ -47,7 +47,7 @@ def configclass(cls, **kwargs): | |||
|
|
|||
| from dataclasses import MISSING | |||
|
|
|||
| from isaaclab.utils.configclass import configclass | |||
| from isaaclabz.utils.configclass import configclass | |||
There was a problem hiding this comment.
💤
Suggested change
| from isaaclabz.utils.configclass import configclass | |
| from isaaclab.utils.configclass import configclass |
Signed-off-by: Harsh Patel <[email protected]>
Signed-off-by: Harsh Patel <[email protected]>
kellyguo11
changed the title
|
A bunch of tests seem to be failing on this one, @jsmith-bdai would you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
- Please approve the
added script to convert urdfs/meshes to instanceable USD in batches #2248first- The exception
if type(obj).__name__ == "MeshConverterCfg": return missing_fieldsis required to get around how the collision mesh schema is setupDescription
Adding new collision mesh property options allowing users to configure meshes to add different collision types
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there