[LLHD] Don't implement BranchOpInterface for WaitOp (#8241)

BranchOpInterface requries the control-flow edges to be side-effect free. However, WaitOp suspends execution and once execution is resumed, values on signals are expected to have changed from outside the process
llvm · Feb 14, 2025 · fa73e07 · fa73e07
1 parent 28a82db
commit fa73e07
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/include/circt/Dialect/LLHD/IR/LLHDStructureOps.td b/include/circt/Dialect/LLHD/IR/LLHDStructureOps.td
@@ -111,7 +111,6 @@ def WaitOp : LLHDOp<"wait", [
     Terminator,
     AttrSizedOperandSegments,
     HasParent<"ProcessOp">,
-    DeclareOpInterfaceMethods<BranchOpInterface>
   ]> {
   let summary = "Suspends execution of a process.";
   let description = [{

diff --git a/lib/Dialect/LLHD/IR/LLHDOps.cpp b/lib/Dialect/LLHD/IR/LLHDOps.cpp
@@ -478,16 +478,6 @@ DrvOp::ensureOnlySafeAccesses(const MemorySlot &slot,
   return success();
 }
 
-//===----------------------------------------------------------------------===//
-// WaitOp
-//===----------------------------------------------------------------------===//
-
-// Implement this operation for the BranchOpInterface
-SuccessorOperands llhd::WaitOp::getSuccessorOperands(unsigned index) {
-  assert(index == 0 && "invalid successor index");
-  return SuccessorOperands(getDestOpsMutable());
-}
-
 //===----------------------------------------------------------------------===//
 // ConnectOp
 //===----------------------------------------------------------------------===//