[Verif] Mark SymbolicValueOp result as MemAlloc #8208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
force-pushed
the
fschuiki/circt-test-contracts
branch
from
0a6b003 to
96404fa
Compare
fabianschuiki
force-pushed
the
fschuiki/symbolic-value-mem-alloc
branch
from
50e4b52 to
71fcaab
Compare
dobios
approved these changes
Feb 8, 2025
Add the `MemAlloc` side effect to the result of `verif.symbolic_value`. This allows the canonicalizer to delete the op if it has no users while still preventing CSE from mergin multiple symbolic values. Also add a few placeholders to the `lower-contracts.mlir` test to make it more robust.
fabianschuiki
force-pushed
the
fschuiki/symbolic-value-mem-alloc
branch
from
71fcaab to
74b5d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
MemAllocside effect to the result ofverif.symbolic_value. This allows the canonicalizer to delete the op if it has no users while still preventing CSE from mergin multiple symbolic values.Also add a few placeholders to the
lower-contracts.mlirtest to make it more robust.