[sw,dif] Port rstmgr_cpu_info_test to DT & update pwrmgr/rstmgr difs for DJ #26270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mundaym
reviewed
Feb 13, 2025
AlexJones0
force-pushed
the
dt_rstmgr_cpu_info
branch
2 times, most recently
from
4dc2626 to
160cc7e
Compare
The docs for this function use non-existent top `english_breakfast` as an example (`englishbreakfast` is the actual name). They also give an example of using an array as a dictionary key, but arrays are non-hashable and so a tuple must be used instead to make a collection as a key. Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Gary Guo <[email protected]> Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
dt_rstmgr_cpu_info
branch
from
160cc7e to
13e5f18
Compare
AlexJones0
changed the title
AlexJones0
requested review from
nbdd0121 and
jwnrt
and removed request for
cfrantz
Adds conditional compilation for Darjeeling to match the changed register definitions, including a change in the number of wakeup reasons for the rstmgr. Ideally this can be better modularised through some devicetable extension API in the future for these blocks, but for now we introduce `ifdef`s to the DIFs to enable this functionality. Signed-off-by: Alex Jones <[email protected]>
Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
dt_rstmgr_cpu_info
branch
from
13e5f18 to
d33d8e1
Compare
nbdd0121
reviewed
Feb 14, 2025
pamaury
approved these changes
Feb 14, 2025
Signed-off-by: Alex Jones <[email protected]>
AlexJones0
force-pushed
the
dt_rstmgr_cpu_info
branch
from
d33d8e1 to
94d65c6
Compare
AlexJones0
changed the title
jwnrt
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26226
This PR ports the
rstmgr_cpu_info_testto use the devicetables API so that it no longer depends on Earlgrey-specific constants. The test remains passing on Earlgrey on FPGA (infpga_cw310_rom_with_fake_keys) and will compile for Darjeeling viaAs part of porting this test, the pwrmgr and rstmgr difs have been updated to support both Earglrey and Darjeeling's IP. This caused issues in bindgen when opentitanlib was compiled due an issue with upstream rules_rust where
rust_bindgen_librarydoes not understand defines set oncc_libraries. This is patched until support is merged upstream. It also fixes the documentation of an unrelated Bazel function which I encountered issues with whilst debugging the aforementioned bindgen issue, though now unrelated to this PR.