Skip to content

8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction #24129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

Anjian-Wen
Copy link
Contributor

@Anjian-Wen Anjian-Wen commented Mar 20, 2025

support Zvbb Vector And-Not vandn.vv (with and without masked) match rule and add new test in jtreg

This patch add new test in
test/hotspot/jtreg/compiler/vectorapi/AllBitsSetVectorMatchRuleTest.java

Test Passed
test/hotspot/jtreg/compiler/vectorapi/*
in platform:
aarch64 with sve
aarch64 without sve
riscv64 qemu with zvbb


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24129/head:pull/24129
$ git checkout pull/24129

Update a local copy of the PR:
$ git checkout pull/24129
$ git pull https://git.openjdk.org/jdk.git pull/24129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24129

View PR using the GUI difftool:
$ git pr show -t 24129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24129.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2025

👋 Welcome back Anjian-Wen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@Anjian-Wen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction

Reviewed-by: fyang, fjiang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@Anjian-Wen The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@Anjian-Wen
Copy link
Contributor Author

/issue JDK-8329887

@openjdk openjdk bot changed the title RISC-V: C2: Support Zvbb Vector And-Not instruction 8329887: RISC-V: C2: Support Zvbb Vector And-Not instruction Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@Anjian-Wen The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 20, 2025

@Anjian-Wen Anjian-Wen marked this pull request as draft March 20, 2025 12:56
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 20, 2025
add Vector And-Not match rule and tests
@Anjian-Wen Anjian-Wen marked this pull request as ready for review March 31, 2025 08:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 31, 2025
@Anjian-Wen Anjian-Wen marked this pull request as draft April 8, 2025 04:04
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 8, 2025
@Anjian-Wen Anjian-Wen marked this pull request as ready for review April 10, 2025 08:50
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 10, 2025
@Anjian-Wen
Copy link
Contributor Author

Appreciate the careful review @RealFYang , I will push a quick modify

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated change looks good. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2025
Copy link
Member

@feilongjiang feilongjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Anjian-Wen
Copy link
Contributor Author

@RealFYang @feilongjiang Thanks for the review and approve

@Anjian-Wen
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@Anjian-Wen
Your change (at version 66c886c) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

Going to push as commit 07aad68.
Since your change was applied there have been 62 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 17, 2025
@openjdk openjdk bot closed this Apr 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@RealFYang @Anjian-Wen Pushed as commit 07aad68.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants