Fix async support #300
Merged
Fix async support #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpepper
requested review from
VachaShah,
dblock,
harshavamsi,
shyim and
saimedhi
as code owners
shyim
approved these changes
Feb 18, 2025
|
This should fix also #296 right? as the options are passed down? |
|
Looks good to me, however I would have appreciated to remain credited as the author for the part I procuded, as per any Open Source project ;) |
|
@kimpepper can you keep his commit and just add yours on top? :) |
Signed-off-by: Kim Pepper <[email protected]> Co-authored-by: Kim Pepper <[email protected]> Co-authored-by: Romain Ruaud <[email protected]>
I added him as a co-author to that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores async support for the legacy transport.
Issues Resolved
#297
#296
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.