Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Composable kube resource logger when test failed #3070

Conversation

simotw
Copy link
Contributor

@simotw simotw commented Feb 18, 2025

Make resource logger composable.

Why are these changes needed?

Ready to apply to other tests.

Screen shots

error logs(the same to #3025)

CleanShot 2025-02-18 at 17 05 05@2x

unsupported resource error

CleanShot 2025-02-18 at 17 04 39@2x

Related issue number

#3069

Checks

This PR depends on the PR #3025 , please review the latest commit 14c452f.

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@simotw simotw changed the title [CI] composable resource logger [CI] Composable kube resource logger when test failed Feb 18, 2025
@simotw simotw marked this pull request as ready for review February 18, 2025 09:07
@simotw simotw force-pushed the ci/dump-failed-test-resources-composable-refactoring branch from 14c452f to 231d044 Compare February 19, 2025 03:16
@kevin85421
Copy link
Member

do we still need #3025?

@kevin85421 kevin85421 self-assigned this Feb 19, 2025
@simotw
Copy link
Contributor Author

simotw commented Feb 19, 2025

do we still need #3025?

Hi @kevin85421 ,
We don't.
I opened this PR just because it's easier to review the changes after last approved PR.

@kevin85421
Copy link
Member

discussed offline:

@simotw I have already merged the PR. Would you mind rebasing with the master branch.

@simotw simotw force-pushed the ci/dump-failed-test-resources-composable-refactoring branch from 231d044 to 41d5c97 Compare February 19, 2025 06:04
@simotw
Copy link
Contributor Author

simotw commented Feb 19, 2025

discussed offline:

@simotw I have already merged the PR. Would you mind rebasing with the master branch.

Thank you @kevin85421 , I have rebased this pr with latest master.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@kevin85421 kevin85421 merged commit 4db24e5 into ray-project:master Feb 19, 2025
20 checks passed
win5923 pushed a commit to win5923/kuberay that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants