Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building an existing tag against a new Scala version #59

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 19, 2017

For tags of the form v1.2.3-suffix#2.13.0-M1, the build script
releases version 1.2.3-suffix using Scala version 2.13.0-M1.

This allows building an existing tag against a new Scala version.

@lrytz
Copy link
Member Author

lrytz commented Apr 19, 2017

Review by @SethTisue. Once this is merged, I'll cherry-pick it on top of v2.0.0 and push a new tag v2.0.0#2.13.0-M1.

@SethTisue
Copy link
Member

@lrytz I won't have time tonight or tomorrow to really think about or properly review this... I think you should just go ahead. maybe comment the script a little better to help our community module maintainers understand what this is about? and/or add a comment to scala/sbt-scala-module#16?

@benhutchison to expand a bit, the context for this is that 2.13.0-M1 is out now and we want to publish all the modules for it, but the existing release script doesn't have a concept of "publish existing module version for new Scala version", all it knows how to do is publish a new module version. so this addresses that by letting us push a special tag to republish an existing module version for a specified Scala version.

@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

OK, thanks Seth. I'll add more documentation and give it a go.

@lrytz lrytz force-pushed the tag-with-scala-version branch 2 times, most recently from 9dbc775 to 18c1db0 Compare April 20, 2017 09:19
For tags of the form `v1.2.3-suffix#2.13.0-M1`, the build script
releases version `1.2.3-suffix` using Scala version `2.13.0-M1`.

This allows building an existing tag against a new Scala version.
@lrytz lrytz force-pushed the tag-with-scala-version branch from 18c1db0 to dc658b5 Compare April 20, 2017 09:22
@lrytz lrytz merged commit 69d6acb into scala:2.0.x Apr 20, 2017
@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

For testing, I created two tags:

It worked as expected, I checked the staging repos on sonatype.

@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

I backported the change to 1.0.x in e56c042 and then merged 1.0.x to 2.0.x in 122070d -- I should have targeted the change to 1.0.x initially, sorry about that noise.

@lrytz
Copy link
Member Author

lrytz commented Apr 20, 2017

I realize i have to add one more dimension (#N) for the java major version, see scala/sbt-scala-module#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants