performance(sierra-to-casm): Avoid intermediate allocation in gas wallet update. #9492
+20
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This was referenced Jan 17, 2026
Merged
|
This change is |
TomerStarkware
approved these changes
Jan 18, 2026
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware).
orizi
changed the base branch from
orizi/01-15-performance_sierra-to-casm_improved_stack-tracking_algorithm
to
graphite-base/9492
…let update. Change gas handling from adding a negated "change" to subtracting a positive "cost", eliminating the intermediate CostTokenMap allocation that was created per-branch via `.iter().map(negate).collect()`. Also take ownership in GasWallet::update to avoid cloning the wallet. - Rename gas_change -> gas_cost to reflect new semantics - Use sub_collection instead of add_collection with negated values - Box GasWalletError in AnnotationError instead of boxing cost field SIERRA_UPDATE_PATCH_CHANGE_TAG=No interface changes.
orizi
force-pushed
the
orizi/01-16-performance_sierra-to-casm_avoid_intermediate_allocation_in_gas_wallet_update
branch
from
078fbc3 to
3250cc3
Compare
orizi
force-pushed
the
graphite-base/9492
branch
from
d54e998 to
3ac037b
Compare
orizi
deleted the
orizi/01-16-performance_sierra-to-casm_avoid_intermediate_allocation_in_gas_wallet_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the gas wallet mechanism in the Sierra-to-CASM compiler to improve error handling and clarify gas cost semantics. The changes include:
GasWalletErrorto reduce memory usagegas_changetogas_costto better reflect its purposesub_collectioninstead ofadd_collectionType of change
Please check one:
Why is this change needed?
The previous implementation had inconsistent semantics around gas costs, where negative values were used for costs and positive values for acquisitions. This made the code harder to understand and maintain. Additionally, the error handling for out-of-gas conditions was verbose and could be improved.
What was the behavior or documentation before?
Before, the gas wallet used
add_collectionwith sign-flipped values, and error messages were less clear about the exact state that caused the out-of-gas condition.What is the behavior or documentation after?
Now, the gas wallet directly uses
sub_collectionwith costs represented as positive values, making the code more intuitive. Error messages are more precise about what caused the out-of-gas condition, and memory usage is reduced by boxing the error type.