performance(orizi): Made allocations for state edits more efficient.

[orizi]

Summary

Optimized the take_args and put_results functions by requiring ExactSizeIterator instead of just Iterator, allowing for pre-allocation of vectors and reserving capacity in hash maps. This change improves performance by reducing memory reallocations during Sierra to CASM compilation.

---

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

---

Why is this change needed?

The current implementation of take_args and put_results functions doesn't pre-allocate memory for the collections they build, which can lead to multiple reallocations as elements are added. By requiring ExactSizeIterator, we can know the size upfront and allocate the right amount of memory once, improving performance.

---

What was the behavior or documentation before?

Previously, the functions accepted any Iterator and allocated collections with default capacity, causing potential reallocations as elements were added.

---

What is the behavior or documentation after?

Now the functions require ExactSizeIterator and use the iterator's length to pre-allocate collections with the exact required capacity, avoiding reallocations.

---

Additional context

This change is particularly beneficial for the Sierra to CASM compilation process, which involves many operations on collections of variable references. The performance improvement will be more noticeable for larger programs with many variables.

[orizi]

• refactor(sierra-to-casm): Made edit_state based on &mut self. #9495
• performance(orizi): Made allocations for state edits more efficient. #9494 👈 (View in Graphite)
• performance(sierra-to-casm): check_types_match accepts iterator - Avoids Vec allocation and ConcreteTypeId clones. #9493
• performance(sierra-to-casm): Avoid intermediate allocation in gas wallet update. #9492
• performance(sierra-to-casm): Improved stack-tracking algorithm. #9491
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[TomerStarkware]

@TomerStarkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware).