refactor(sierra-to-casm): Made edit_state based on &mut self.

[orizi]

Summary

Refactored variable state management in Sierra by introducing an EditState trait to replace the standalone take_args and put_results functions. This change improves code organization by moving the state manipulation logic into a trait implementation for OrderedHashMap<VarId, V>.

---

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

---

Why is this change needed?

The previous approach used standalone functions to manipulate variable state, which required returning a new state object each time. This led to more verbose code with multiple variable reassignments. The new trait-based approach allows for more idiomatic in-place modifications, making the code cleaner and easier to maintain.

---

What was the behavior or documentation before?

Previously, state manipulation required calling standalone functions take_args and put_results that would return a new state object, requiring explicit reassignment:

let (statement_refs, taken_refs) = take_args(entry.refs, ref_ids)?;
entry.refs = statement_refs;

---

What is the behavior or documentation after?

Now, state manipulation is done through the EditState trait methods that modify the state in-place:

let taken_refs = entry.refs.take_vars(ref_ids)?;

This eliminates the need for explicit reassignment and makes the code more concise.

---

Additional context

This change maintains the same functionality while improving code organization. The implementation updates all relevant code in the Sierra codebase to use the new trait methods, including tests that verify the behavior remains consistent.

[orizi]

• refactor(sierra-to-casm): Made edit_state based on &mut self. #9495 👈 (View in Graphite)
• performance(orizi): Made allocations for state edits more efficient. #9494
• performance(sierra-to-casm): check_types_match accepts iterator - Avoids Vec allocation and ConcreteTypeId clones. #9493
• performance(sierra-to-casm): Avoid intermediate allocation in gas wallet update. #9492
• performance(sierra-to-casm): Improved stack-tracking algorithm. #9491
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[eytan-starkware]

@eytan-starkware reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @orizi and @TomerStarkware).

---

crates/cairo-lang-sierra/src/edit_state.rs line 28 at r1 (raw file):

/// Trait for editing the state of variables in a map.
pub trait EditState<V> {
    /// Extracts out the given ids from the map, failing if some id is missing.

Extracts = removes. Please improve comment to be clear

---

crates/cairo-lang-sierra/src/edit_state_test.rs line 6 at r1 (raw file):

use crate::edit_state::{EditState, EditStateError};
use crate::ids::VarId;

The tests seem roundabout. Why hide the map behind a new take and put functions, and then create the map with a from?

[TomerStarkware]

@TomerStarkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi).

[orizi]

@orizi made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eytan-starkware).

---

crates/cairo-lang-sierra/src/edit_state.rs line 28 at r1 (raw file):

Previously, eytan-starkware wrote…

Extracts = removes. Please improve comment to be clear

Done.

---

crates/cairo-lang-sierra/src/edit_state_test.rs line 6 at r1 (raw file):

Previously, eytan-starkware wrote…

The tests seem roundabout. Why hide the map behind a new take and put functions, and then create the map with a from?

because it makes the tests short.

[eytan-starkware]

@eytan-starkware reviewed 4 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi).