-
Notifications
You must be signed in to change notification settings - Fork 10
Docs overhaul #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Docs overhaul #431
Conversation
/preview-docs |
🚀 Deployed on https://67f5a1065c980a95c56b327c--epipredict.netlify.app |
Also FYI: the bot edits its own comment for links. Each preview is a separate link and the links stick around for like 90 days. You can see the previous links in the comment edit history. |
8044b98
to
d35363e
Compare
/preview-docs |
So something weird is happening with the plot for I added an option to replace the data for the autoplot so you can compare with new data instead |
Draft of the getting started is ready, moving on to a draft of the "guts" page (name a placeholder), which is an overview of creating workflows by hand |
/preview-docs |
Including 0.5 into the user's selection sounds simple and reasonable to me. They can always filter out what they don't want. |
/preview-docs |
/preview-docs @nmdefries this also updates the backtesting vignette; I'm dropping the Canadian example because it basically had no revisions. |
/preview-docs |
My linewrapping preference is largely due to code review:
But the specifics don't matter to me so much. |
\preview-docs |
library(ggplot2) | ||
library(purrr) | ||
forecast_date <- as.Date("2021-08-01") | ||
used_locations <- c("ca", "ma", "ny", "tx") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: make these visible in the code, so the vignette code can be reproduced by someone following along.
Checklist
Please:
dajmcdon.
DESCRIPTION
andNEWS.md
.Always increment the patch version number (the third number), unless you are
making a release PR from dev to main, in which case increment the minor
version number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
0.7.2, then write your changes under the 0.8 heading).
epiprocess
version in theDESCRIPTION
file ifepiprocess
soonepipredict
andepiprocess
Change explanations for reviewer
Draft ready for review:
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
symmetrize
for residuals #264nafill_buffer
usage #320