Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul logging integration. #123

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Overhaul logging integration. #123

merged 2 commits into from
Jun 4, 2018

Conversation

amilstead
Copy link
Contributor

  • Update README to reflect more modern install conventions.
  • Refactor SimpleLogger/NoOpLogger to use standard python logging.
  • Update tests.

Overhaul logging integration.
488c741 
Summary:
* Update README to reflect more modern install conventions.
* Refactor SimpleLogger/NoOpLogger to use standard python logging.
* Update tests.

Test Plan: CI

Reviewers: ali

Differential Revision: https://phabricator.optimizely.com/D19843
@amilstead amilstead requested a review from aliabbasrizvi June 1, 2018 23:24
@coveralls
Copy link

coveralls commented Jun 4, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.649% when pulling 24138db on amilstead/logging-overhaul into cca95a6 on master.

aliabbasrizvi
aliabbasrizvi approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amilstead amilstead merged commit ed98b85 into master Jun 4, 2018
@amilstead amilstead deleted the amilstead/logging-overhaul branch June 4, 2018 19:10
This was referenced Jan 7, 2019
Closed
Merged
@oakbani oakbani mentioned this pull request Mar 21, 2019
Merged
@asaschachar asaschachar mentioned this pull request Apr 10, 2019
Merged
This was referenced Jul 5, 2019
Merged
Merged
This was referenced Jul 19, 2019
Closed
Merged
This was referenced Aug 1, 2019
Open
Open
@mnoman09 mnoman09 mentioned this pull request Aug 16, 2019
Merged
This was referenced Sep 12, 2019
Merged
Merged
@oakbani oakbani mentioned this pull request Oct 4, 2019
Merged
@oakbani oakbani mentioned this pull request Dec 6, 2019
Merged
@thomaszurkan-optimizely thomaszurkan-optimizely mentioned this pull request Dec 14, 2019
Merged
@juancarlostong juancarlostong mentioned this pull request Feb 7, 2020
Merged
@yavorona yavorona mentioned this pull request May 14, 2020
Merged
@oakbani oakbani mentioned this pull request Jul 13, 2020
Merged
@AmnaEjaz AmnaEjaz mentioned this pull request Jul 16, 2020
Closed
@msohailhussain msohailhussain mentioned this pull request Jul 16, 2020
Draft
@oakbani oakbani mentioned this pull request Jul 24, 2020
Merged
@AmnaEjaz AmnaEjaz mentioned this pull request Jul 30, 2020
Merged
@msohailhussain msohailhussain mentioned this pull request Aug 20, 2020
Closed
@oakbani oakbani mentioned this pull request Sep 15, 2020
Merged
This was referenced Jan 21, 2021
Closed
Open
@msohailhussain msohailhussain mentioned this pull request Mar 4, 2021
Merged
@graingert graingert mentioned this pull request Apr 1, 2021
Closed
@ozayr-zaviar ozayr-zaviar mentioned this pull request Apr 26, 2021
Closed
@Mat001 Mat001 mentioned this pull request May 5, 2021
Closed
@GordonSo GordonSo mentioned this pull request May 7, 2021
Closed
@The-inside-man The-inside-man mentioned this pull request Jul 9, 2021
Closed
@shujat333 shujat333 mentioned this pull request Jul 9, 2021
Closed
@GordonSo GordonSo mentioned this pull request Sep 9, 2021
Closed
@msohailhussain msohailhussain mentioned this pull request Nov 29, 2021
Merged
@ozayr-zaviar ozayr-zaviar mentioned this pull request Jun 28, 2022
Merged
@Mat001 Mat001 mentioned this pull request Aug 4, 2022
Merged
@FarhanAnjum-opti FarhanAnjum-opti mentioned this pull request Dec 10, 2024
Closed
@pvcraven pvcraven mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliabbasrizvi aliabbasrizvi aliabbasrizvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amilstead @coveralls @aliabbasrizvi