feat: add C implementation for math/base/special/gamma-lanczos-sum
#1834
+1,307
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Planeshifter
added
Needs Review
kgryte
added
Feature
kgryte
reviewed
Mar 11, 2024
...lib/math/base/special/gamma-lanczos-sum/include/stdlib/math/base/special/gamma_lanczos_sum.h
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 11, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/lib/native.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 11, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/lib/native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 11, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 11, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 11, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
requested changes
Mar 11, 2024
There was a problem hiding this comment.
@gunjjoshi Thanks for working on this. Left a comment regarding the implementation. Once the implementation is updated using code generation, this should be on the path to merging.
Signed-off-by: Athan <kgryte@gmail.com>
|
Thanks for pointing this out @kgryte. I have modified |
Pranavchiku
added
Needs Changes
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/scripts/evalrational.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/scripts/evalrational.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/src/main.c
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/special/gamma-lanczos-sum/src/main.c
Outdated
Show resolved
Hide resolved
PR-URL: #1930 --------- Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
…odd` PR-URL: #1935 Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in>
PR-URL: #1937 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Reviewed-by: Planeshifter <1913638+Planeshifter@users.noreply.github.com>
PR-URL: #1919 Closes: #1917 --------- Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com> Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in> Co-authored-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: #1909 --------- Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com> Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in> Co-authored-by:Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: #1918 Closes: #1901 --------- Signed-off-by: Rutam <138517416+performant23@users.noreply.github.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
R linting seems to be broken on CI, see `lint_random_files.yml` workflow run such as the following: https://github.com/stdlib-js/stdlib/actions/runs/8319437589/job/22762740425#step:15:988 This PR updates the installed R version to see if that resolves the issue as all dependencies are correctly installed from CRAN locally when ussing that version.
PR-URL: #1940 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Reviewed-by: Planeshifter <1913638+Planeshifter@users.noreply.github.com>
PR-URL: #1941 Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: #1956 Signed-off-by: stdlib-bot <82920195+stdlib-bot@users.noreply.github.com> Co-authored-by: kgryte <2643044+kgryte@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR-URL: #1958 Reviewed-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in>
The seed for MT19937 must be a nonzero positive integer, as discussed in the original paper describing the Mersenne Twister PRNG. Closes: #1963
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1822
Description
This pull request:
math/base/special/gamma-lanczos-sum.Related Issues
This pull request:
@stdlib/math/base/special/gamma-lanczos-sum#1822Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers