Bug fix: Optional sequences shouldn't be defaulted to null #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inexorabletash
changed the title
inexorabletash
force-pushed
the
bugfix-sequence-options-null
branch
from
d2ce8d3 to
65cfca3
Compare
|
Looks right to me. Like you said, the intention is that you may omit optional |
huningxin
approved these changes
Feb 2, 2024
inexorabletash
force-pushed
the
bugfix-sequence-options-null
branch
from
65cfca3 to
ef800fb
Compare
fdwr
approved these changes
Feb 6, 2024
MLArgMinMaxOptions and MLReduceOptions have an 'axes' member that the IDL declares as defaulting to null. They have type sequence<unsigned long> which is not nullable. The intent is that these are optional members with default behavior if not present, which is handled in the algorithm already.
inexorabletash
force-pushed
the
bugfix-sequence-options-null
branch
from
ef800fb to
44d5e0b
Compare
|
Merging this. Chai is on the reviewers list for this CR, but we don't need to wait for his review (after speaking with him, there's a select set of reviews and topics he's interested in, but otherwise he won't be looking at every CR). Thanks Josh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLArgMinMaxOptions and MLReduceOptions have an 'axes' member that the IDL declares as defaulting to null. They have type sequence which is not nullable. The intent is that these are optional members with default behavior if not present, which is handled in the algorithm already.
If the desire is to be able to explicitly pass null, the IDL fix would be to make the type nullable:
sequence<unsigned long>? axes = null;but that's inconsistent with the rest of the spec and not the convention for optional dictionary members.Preview | Diff