Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce MAX32660 SoC #85733

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Introduce MAX32660 SoC #85733

merged 5 commits into from
Feb 14, 2025

Conversation

yasinustunerg
Copy link
Collaborator

This PR

Signed-off-by: Yasin Ustuner [email protected]
Signed-off-by: Matthew McClintock [email protected]

@yasinustunerg yasinustunerg changed the title soc: adi: Add MAX32660 SoC Introduce MAX32660 SoC Feb 13, 2025
@yasinustunerg yasinustunerg force-pushed the Introduce-MAX32660-SoC branch 4 times, most recently from 107c5b7 to 1b2a3bc Compare February 13, 2025 20:01
@yasinustunerg yasinustunerg marked this pull request as ready for review February 13, 2025 20:02
@zephyrbot zephyrbot added area: Clock Control area: DMA Direct Memory Access platform: ADI Analog Devices, Inc. labels Feb 13, 2025
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 13, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_adi zephyrproject-rtos/hal_adi@13a3f2d zephyrproject-rtos/hal_adi@633fcec (main) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_adi DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Feb 13, 2025
@yasinustunerg
Copy link
Collaborator Author

This PR is dependent on #85572 for HWINFO solution.

@MaureenHelm MaureenHelm added this to the v4.1.0 milestone Feb 13, 2025
MaureenHelm
MaureenHelm reviewed Feb 13, 2025
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve the dependency and address one minor nit, but otherwise looks good

@MaureenHelm MaureenHelm force-pushed the Introduce-MAX32660-SoC branch from 1b2a3bc to 4142f9c Compare February 14, 2025 00:56
@zephyrbot zephyrbot added area: HWINFO Hardware Information Driver area: UART Universal Asynchronous Receiver-Transmitter labels Feb 14, 2025
@MaureenHelm
Copy link
Member

To get a clean twister run, I made the following changes:

@kartben @fabiobaltieri This PR won't quite be 48 hours old before you close the merge window, but I'd like to get it into 4.1 if you're willing to exercise your discretion as release managers. And of course if it passes CI and has the required approvals.

@fabiobaltieri
Copy link
Member

@kartben @fabiobaltieri This PR won't quite be 48 hours old before you close the merge window, but I'd like to get it into 4.1 if you're willing to exercise your discretion as release managers. And of course if it passes CI and has the required approvals.

Yeah just make sure zephyrproject-rtos/hal_adi#18 gets through and the manifest points to the right sha

@MaureenHelm MaureenHelm force-pushed the Introduce-MAX32660-SoC branch from d1211cc to 9d46573 Compare February 14, 2025 11:32
@zephyrbot zephyrbot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 14, 2025
fabiobaltieri
fabiobaltieri previously approved these changes Feb 14, 2025
View reviewed changes
MaureenHelm
MaureenHelm previously approved these changes Feb 14, 2025
View reviewed changes
ozersa
ozersa previously approved these changes Feb 14, 2025
View reviewed changes
kartben
kartben previously approved these changes Feb 14, 2025
View reviewed changes
@yasin-ADI
manifest: Add MAX32660 hal files
a68e367 
This commit adds necessary hal files
for MAX32660 board.

Signed-off-by: Yasin Ustuner <[email protected]>
@yasin-ADI
soc: adi: Add MAX32660 SoC
e1d30d2 
This commit adds MAX32660 SoC
and dts files.

Signed-off-by: Yasin Ustuner <[email protected]>
@yasin-ADI
include: zephyr: dt-bindings: Add MAX32660 DMA binding
dc755b0 
This commit adds binding file for DMA slots

Signed-off-by: Yasin Ustuner <[email protected]>
@yasin-ADI
drivers: clock control: Update IBRO Clock for MAX32
b999aba 
This commit updates ADI_MAX32_CLK_IBRO_FREQ
macro because MAX32660 does not support
IBRO clock.

Signed-off-by: Yasin Ustuner <[email protected]>
@yasin-ADI
boards: adi: Add MAX32660EVSYS board
b4dacce 
This commit adds MAX32660EVSYS board
basic port.

Signed-off-by: Yasin Ustuner <[email protected]>
Signed-off-by: Matthew McClintock <[email protected]>
@yasinustunerg
Copy link
Collaborator Author

All tests are passed.

@kartben
Copy link
Collaborator

kartben commented Feb 14, 2025

"fast tracking" by a few hours so that it makes it into 4.1 rc1

@kartben kartben merged commit ef1d629 into zephyrproject-rtos:main Feb 14, 2025
25 checks passed
@MaureenHelm
Copy link
Member

"fast tracking" by a few hours so that it makes it into 4.1 rc1

Thanks @kartben !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@ozersa ozersa ozersa approved these changes

@galak galak Awaiting requested review from galak

@microbuilder microbuilder Awaiting requested review from microbuilder

@nordic-krch nordic-krch Awaiting requested review from nordic-krch

@teburd teburd Awaiting requested review from teburd

@ttmut ttmut Awaiting requested review from ttmut

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@dcpleung dcpleung Awaiting requested review from dcpleung

@kartben kartben Awaiting requested review from kartben

Assignees

@MaureenHelm MaureenHelm

Labels
area: Clock Control area: DMA Direct Memory Access area: HWINFO Hardware Information Driver area: UART Universal Asynchronous Receiver-Transmitter manifest manifest-hal_adi platform: ADI Analog Devices, Inc.
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@yasinustunerg @zephyrbot @MaureenHelm @fabiobaltieri @kartben @ozersa @nordic-krch @yasin-ADI